Check for win?

[|2eM!x]

As i posted last night, i was making a game of tic-tac-toe.
Im pretty much done, i just dont know how to add a win check. Once i get that ill make it winsock for online fun ; )..Heres the code:

Option Explicit
Dim x, y As Integer
Dim teamname, compname As String
 
Private Sub Form_Load()
    Call Restart1
End Sub
 
Private Sub Restart_Click()
    Call Restart1
End Sub
 
Private Sub xolbl_Click(Index As Integer)
If Len(xolbl(Index).Caption) > 0 Then Exit Sub
  Select Case teamname
        Case "x"
             xolbl(Index).Caption = "x"
        Case "o"
             xolbl(Index).Caption = "o"
    End Select
    Call rndfunc
    Call addblock
End Sub
 
Private Sub rndfunc()
        y = Int((8 * Rnd) + 1)
      '  MsgBox y
End Sub
 
Private Sub changeteams()
    Select Case teamname
        Case "x"
            compname = "o"
        Case "o"
            compname = "x"
    End Select
    If Len(xolbl(y)) > 0 Then
            Call rndfunc
            Call addblock
            End If
End Sub
 
Private Sub addblock()
On Error GoTo errhndlr
        If Len(xolbl(y)) > 0 Then
            Call rndfunc
            Call changeteams
        Else
            Call changeteams
            xolbl(y) = compname
        End If
        xolbl(y) = compname
        Call Checkforwin
errhndlr:
    If Len(Err.Description) > 0 Then
        MsgBox Err.Number & Err.Description & " Source " & Err.Source
    End If
End Sub
 
Private Sub Checkforwin()
    
End Sub
 
Private Sub Restart1()
Dim i As Integer
Randomize
    x = Int((2 * Rnd) + 1)
    If x = 2 Then
        teamname = "x"
    Else
        teamname = "o"
    End If
    For i = 0 To xolbl.UBound
    xolbl(i).Caption = vbNullString
 Next i
 You.Caption = "You = " & teamname
End Sub

How do i check for three in a row?

[Joacim Andersson]

I'm guessing that your label array is arranged like this:
012
345
678

There is only 5 ways someone can win. If the labels 0, 1, and 2 have the same caption. If label 3, 4, and 5 have the same caption. If label 6, 7, and 8 have the same caption. If labels 0, 4, and 8 have the same caption. If labels 2, 4, and 6 have the same caption. I guess you just have to check that. Of course the same caption doesn't mean an empty string in all positions

[Turiya]

There are actually eight

012
345
678
036
147
258
048
246

[Turiya]

have a little code, it's untested...
Private Function checkforwin() As Boolean
If xolbl(0).Caption = xolbl(1).Caption And xolbl(1).Caption = xolbl(2).Caption And Len(xolbl(1).Caption) <> 0 Then checkforwin = True
If xolbl(3).Caption = xolbl(4).Caption And xolbl(4).Caption = xolbl(5).Caption And Len(xolbl(1).Caption) <> 0 Then checkforwin = True
If xolbl(6).Caption = xolbl(7).Caption And xolbl(7).Caption = xolbl(8).Caption And Len(xolbl(1).Caption) <> 0 Then checkforwin = True
If xolbl(0).Caption = xolbl(3).Caption And xolbl(3).Caption = xolbl(6).Caption And Len(xolbl(1).Caption) <> 0 Then checkforwin = True
If xolbl(1).Caption = xolbl(4).Caption And xolbl(4).Caption = xolbl(7).Caption And Len(xolbl(1).Caption) <> 0 Then checkforwin = True
If xolbl(2).Caption = xolbl(5).Caption And xolbl(5).Caption = xolbl(8).Caption And Len(xolbl(1).Caption) <> 0 Then checkforwin = True
If xolbl(2).Caption = xolbl(4).Caption And xolbl(4).Caption = xolbl(6).Caption And Len(xolbl(1).Caption) <> 0 Then checkforwin = True
If xolbl(0).Caption = xolbl(4).Caption And xolbl(4).Caption = xolbl(8).Caption And Len(xolbl(1).Caption) <> 0 Then checkforwin = True
End Function

Called like so (pseudocode)
Xplays
if Checkforwin then
msgbox "X wins!"
restartgame
end if
Oplays
if Checkforwin then
msgbox "O wins!"
restartgame
end if

[Mc Brain]

This is how I'd do it

[|2eM!x]

Turiya, i like your code. ill try it ; )

[Mc Brain]

Turiya's code is not checking for empty values, either (Mine was not checking it because it was not checking play-by-play but at the end). After the first play, that code would find one line or column (and possibly a diagonal too) which has all the position equalls to "". For example, I play my "X" in the center box... the line If xolbl(0).Caption = xolbl(1).Caption And xolbl(1).Caption = xolbl(2).Caption Then checkforwin = True will fit the condition and your code would yield I won. You should bear that in mind.

[|2eM!x]

I got it to work, is there a neater way of doing it though?

[Mc Brain]

Have a look at this full-working code. Now you can play.

[|2eM!x]

Yes it works, but it seems you over complicated the game a little too much...

[Mc Brain]

Yes it works, but it seems you over complicated the game a little too much...

You asked for a neater way. I think that's as neat as it could be done. I could add some comments lines... but you don't seem willing to learn from it, so it would be a waste of time.

[Mc Brain]

In other words... a neater code would be a code that would let you (in the future) upgrade it so that you can let the user decide how many rows and columns he wants without modifying the whole code. My code would need to use a variable instead of all of those "2" (or "3"), and a little modification on the diagonal checking (because there would be more than 2 diagonals if there are more than 9 squares). That's neat!!

The other way (proposed coding) you should limit the number of lines and/or columns the user wants and write a load of IF lines as above according to the number of lines and/or columns the user wanted.

[|2eM!x]

im sorry dude, but your code is either to advanced, or not exactly what im looking for. I in no way meant to offend you as it seems i did

[Mc Brain]

Don't worry. You did not offend me. I was just trying to make my point. If you want a neater way... you should build up your knowledge to understand and code harder things. For example, here's the first hint:

Select Case teamname
        Case "x"
             xolbl(Index).Caption = "x"
        Case "o"
             xolbl(Index).Caption = "o"
    End Select

This code makes no sense at all. A neater way would be

xolbl(Index).Caption = teamname

[|2eM!x]

jeez, never even thought of that

[Turiya]

If the guy doesn't want to change his code like that, he doesn't have to. I used to have messy code back in grade 7 and 8, I have neater code now, but I think that if the code works, you have a good program, if you have code that does what you want, you're amazing.

[|2eM!x]

yup it works good, except i hate all the if statements

[Mc Brain]

Hey! I'm not forcing anyone here! I don't want him to change all his program. He asked for a neater way and I posted an example. If he does not want to implement something like that... he won't do it.

[Turiya]

Sorry, I meant no offense

[Mc Brain]

yup it works good, except i hate all the if statements

No Ifs, but Fors... and a much simpler way.

[Mc Brain]

Sorry, I meant no offense

Not taken.

[|2eM!x]

Yes, but i dont understand it

[Mc Brain]

Yes, but i dont understand it

The CheckForWinners calls the functions CheckForLines, CheckForColumns and CheckForDiagonals.

Private Function CheckForLines() As Boolean
    Dim sValue As String
    
    For iLine = 0 To 2
        'We'll start with the first line... that's Line=0, then Line=1 and finally Line=2
        iColumn = 0  'Set the column variable to the first one.
        sValue = arr(Index)  'Load the variable sValue with the content of the
                                    'first element on this line. This is the one that's
                                    'on Column=0
        
        For iColumn = 1 To 2
            'We'll check the other two values (Column=1 and Column=2)                
            If sValue <> arr(Index) Or sValue = "" Then
                'The value in this square does not match with the value in 
                'the first column (sValue)... 
                'or the value in the first square was empty.
                Exit For
            End If
        Next iColumn
        
        If iColumn > 2 Then
            'If we get here... the three columns have the same value and did not
            'did not "EXIT FOR".    
            CheckForLines = True
        End If
    Next iLine
End Function

The other functions (CheckForColumns and CheckForDiagonals) are very similar.

BTW, it seems you did not download the latest code (Tic-Tac-Toe.zip (5.1 KB, 0 views)). It's much simpler than the one I posted first. As you can see in this post, the functions returns a boolean instead of a collection.

[|2eM!x]

cool, can you tell me why sometimes, this doesnt clear one label?

Private Sub Restart1()
Dim i As Integer
Randomize
    x = Int((2 * Rnd) + 1)
    If x = 2 Then
        teamname = "x"
    Else
        teamname = "o"
    End If
    For i = 0 To xolbl.UBound
    xolbl(i).Caption = vbNullString
 End If
 Next i
End Sub

xolbl(i).Caption = vbNullString, that should clear alll in the array, but it leaves the last selected box sometimes..do you know why?

[Mc Brain]

cool, can you tell me why sometimes, this doesnt clear one label?

Private Sub Restart1()
Dim i As Integer
Randomize
    x = Int((2 * Rnd) + 1)
    If x = 2 Then
        teamname = "x"
    Else
        teamname = "o"
    End If
    For i = 0 To xolbl.UBound
    xolbl(i).Caption = vbNullString
 End If
 Next i
End Sub

xolbl(i).Caption = vbNullString, that should clear alll in the array, but it leaves the last selected box sometimes..do you know why?

First tell me what's this END IF is for....

Private Sub Restart1()
Dim i As Integer
Randomize
    x = Int((2 * Rnd) + 1)
    If x = 2 Then
        teamname = "x"
    Else
        teamname = "o"
    End If
    For i = 0 To xolbl.UBound
    xolbl(i).Caption = vbNullString
 End If  '<---- What is this for??
 Next i
End Sub

[|2eM!x]

its not there, i realized it was dumb code when i posted it, so i deleted it and forgot the end if, its not there in code

[Mc Brain]

And which one is the one that's not being cleared?

[|2eM!x]

Its different every time, its usually the last one clicked

[Mc Brain]

Then... I'm guessing the problem is that it's caption is being re-written after you've deleted ots contents. Place a breakpoint at the end of the routine and check if it everything is Ok. If it does... you have the answer.