problem with function[SOLVED]

[vigge89]

I've got this code in an module:

Public Function GetScreenPixels(Optional Dimension As Integer, Optional MinusForm As Form)
 
If Not MinusForm Is Nothing Then 'Get maximum position for form
 
    If Dimension = 1 Then 'Y
        GetScreenPixels = (Screen.Height - MinusForm.Height) / Screen.TwipsPerPixelY
    Else 'X
        GetScreenPixels = (Screen.Width - MinusForm.Width) / Screen.TwipsPerPixelX
    End If
 
Else 'Get screen size in pixels
 
    If Dimension = 1 Then 'Y
        GetScreenPixels = Screen.Height / Screen.TwipsPerPixelY
    Else 'X
        GetScreenPixels = Screen.Width / Screen.TwipsPerPixelX
    End If
    
End If
 
End Function

The function is for returning the users screen width and height in pixels. however, when i use this code to call it;

Private Sub txtPosX_LostFocus()
On Error GoTo Error
 
'Allow form to edit values
If auto_change = True Then Exit Sub
 
If txtPosX.Text > GetScreenPixels(0) Then
    MsgBox ("Outside screen!")
    txtPosX.Text = GetScreenPixels(0, frmMain)
End If
 
Exit Sub
 
Error:
MsgBox ("Only numbers are allowed as window positions!")
txtPosX.Text = 0
 
End Sub
 
Private Sub txtPosY_LostFocus()
On Error GoTo Error
 
'Allow form to edit values
If auto_change = True Then Exit Sub
 
If txtPosY.Text > GetScreenPixels(1) Then
    MsgBox ("Outside screen!")
    txtPosY.Text = GetScreenPixels(1, frmMain)
End If
 
Exit Sub
 
Error:
MsgBox ("Only numbers are allowed as window positions!")
txtPosY.Text = 0
 
End Sub

It doesn't work. My resolotion is 1280x1024. When changing the txtPosX text to a number which is more than 1, i get "Outside screen!". changing txtPosY doesn't work either, only numbers below 1 are accepted.

Does anyone have a solution to this?

[MartinLiss]

Change the comparison to

If [b]Val[/b](txtPosX.Text) > GetScreenPixels(0) Then

[MartinLiss]

Put a proper return type on the function and it also works.

Public Function GetScreenPixels(Optional Dimension As Integer, Optional MinusForm As Form) [b]As Integer[/b]

[vigge89]

great, i tried "Int(txtPosX)" before, but i wasn't sure that it did that

thanks!