Checing for a SubString -[RESOLVED]-

[Electroman]

I am using this code in my counter to stop it counting known robots as unique hits

if (strpos($_SERVER['HTTP_USER_AGENT'],'SurveyBot'))
{
  $IsRobot = true;
} 

This is used with more elseif's in order to go though all the robots I know of so far. However I still seem to be getting my Counter creating records in my Db that say the User Agent is "SurveyBot/2.3 (Whois Source)" even witht he code above. Have I made a mistake in the code above you do you recon the problem may be with another part in my code?

Thanx for any help.

[kows]

Try this out:

if(strstr($_SERVER['HTTP_USER_AGENT'], 'SurveyBot')){
  $IsRobot = true;
}elseif(.... 

I've always used strstr(), strpos() didn't work for me the first time I wanted to see if a string occured within another, so it's just stuck in my head for what I use. It's said to be slower and use more memory, but see if that helps.

Or, you could try:

if(strpos($_SERVER['HTTP_USER_AGENT'], 'SurveyBot') === true){
  $IsRobot = true;
}elseif(.... 

[john tindell]

If you want to use strpos try this

if (strpos($_SERVER['HTTP_USER_AGENT'],'SurveyBot') == false)
{
  $IsRobot = true;
} 

Kows: It returns an integer if it finds the string. So if the string is at the start it will return 0, which is also evaluated to false in an IF statement.

[Electroman]

Thanx, Mind the strings i'm using might be part way though as well, not all of them are at the beginning though.

[Electroman]

Opps, I thought I had made this change in the first example:

if (strpos(" ".$_SERVER['HTTP_USER_AGENT'],'SurveyBot')) 
{ 
  $IsRobot = true; 
} 

[CornedBee]

Actually to check for failure of strpos, use
strpos(...) === false
(notice the triple equals), because otherwise 0 gets interpreted as false.

Alternatively I think there's an in_string or instr function.

[Electroman]

Thanx guys, I have just had google bot return to my site and confirm it now works with:

if (strpos(' '.$_SERVER['HTTP_USER_AGENT'],'Mediapartners-Google') != 0)
{
  $UserID = 270;
} 

So I guess I'll keep it like this until I get some time to look at the in_string function CornedBee mentioned.