Best Load Code - Lol

[_Vb_N00bie_]

Ok well im just curious about the load code now and this is what I use at the time:

On Error GoTo 1
    With CD1
        .DialogTitle = "Open User File"
        .Filter = "All Supported Types|*.usr;*.txt;*.dat|"
        .ShowOpen
Dim sText As String
    Dim x As Integer
    x = FreeFile
    On Error Resume Next
    Open .FileName For Input As #x
    While Not EOF(x)
        Input #x, sText$
            If sText$ = "" Then
            Exit Sub
            Else
            List1.AddItem sText$
            DoEvents
            End If
    Wend
    Close #x
        End With
    Exit Sub
1
Exit Sub

Im just looking for advice on what the best load code is and if anything here could be changed to make it better? Thanks guys I appreciate your help

[techyspecy]

What is this, some god damn game ?

Its fine.

[_Vb_N00bie_]

Well no im just using a lot of save and load functions and some people have said its not the ebst code to use so I wanted to ask to see if it was the best so thanks for your help man

[BuggyProgrammer]

if you want best, try leaning toward building your own OS, then you will have much more direct access to the drive.

really, it's fine

[techyspecy]

Originally posted by _Vb_N00bie_
Ok well im just curious about the load code now and this is what I use at the time:

On Error GoTo 1
    With CD1
        .DialogTitle = "Open User File"
        .Filter = "All Supported Types|*.usr;*.txt;*.dat|"
        .ShowOpen
Dim sText As String
    Dim x As Integer
    x = FreeFile
    On Error Resume Next
    Open .FileName For Input As #x
    While Not EOF(x)
        Input #x, sText$
            If sText$ = "" Then
            Exit Sub
            Else
            List1.AddItem sText$
            DoEvents
            End If
    Wend
    Close #x
        End With
    Exit Sub
1
Exit Sub

Im just looking for advice on what the best load code is and if anything here could be changed to make it better? Thanks guys I appreciate your help

Hang on, there is a problem in this code.

While Not EOF(x)
        Input #x, sText$
            If sText$ = "" Then
            Exit Sub
            Else
            List1.AddItem sText$
            DoEvents
            End If
    Wend

If sText$ = "" Then
Exit Sub
Else

if text is blank you are exitting the sub. Well, what if there is some blank line in between and there is text after that.

I mean, lets say text file contains ..

1
2
3

5

7

4
4
4


77

as soon as it will detect the blank after 3, it will exit the sub. While there is data after that. Isn't it ?

You should rather say ..

While Not EOF(x)
        Input #x, sText$
        If trim(sText$) <> "" Then
             List1.AddItem sText$
        End If
        DoEvents
    Wend

[MartinLiss]

More standard formatting.

Dim sText As String
    Dim x As Integer
    
    On Error GoTo ErrorExit
    
    With CD1
        .DialogTitle = "Open User File"
        .Filter = "All Supported Types|*.usr;*.txt;*.dat|"
        .ShowOpen
        x = FreeFile
        On Error Resume Next
        Open .FileName For Input As #x
        While Not EOF(x)
            Input #x, sText$
            If sText$ = "" Then
                Exit Sub
            Else
                List1.AddItem sText$
                DoEvents
            End If
        Wend
        Close #x
    End With
    
    Exit Sub
    
ErrorExit:
 
    Exit Sub
    
End Sub