How can I make this code better??? Winsock Related

[Daskalos]

hi... I using this code for a chat program....
Is there a way to use only one Winsock to send and recive data??
I also want that when someone request a connection, both sides conects....

''''''''''Server code
Dim intMax As Integer
 
Private Sub Command2_Click()
    Winsock2.SendData "(" & Format(Time, "HH:MM") & ") " & Winsock2.LocalHostName & " »»>  " & Text1.Text
    List1.AddItem "(" & Format(Time, "HH:MM") & ") " & Winsock2.LocalHostName & " »»>  " & Text1.Text
    Text1.Text = ""
    Text1.SetFocus
End Sub
 
 
Private Sub Form_Load()
    Me.Winsock1(0).LocalPort = GetSetting(App.EXEName, "Options", "Port", "6668")
    Winsock1(0).Listen
    List1.AddItem "(" & Format(Time, "HH:MM") & ") " & Winsock2.LocalHostName & " »»>  " & Text1.Text
 
End Sub
 
 
Private Sub Text1_KeyPress(KeyAscii As Integer)
If KeyAscii = vbKeyReturn Then
    Command2_Click
End If
End Sub
 
Private Sub Winsock1_Close(Index As Integer)
    Winsock1(Index).SendData "Conexão Fechada para:" & Winsock1(Index).RemoteHostIP & "  Em: " & Now
    Winsock1(Index).Close
    List1.AddItem "Conexão Fechada para:" & Winsock1(Index).RemoteHostIP & "  Em: " & Now
End Sub
 
 
Private Sub Winsock1_ConnectionRequest(Index As Integer, ByVal requestID As Long)
    If Index = 0 Then
        intMax = intMax + 1
        Load Winsock1(intMax)
        Winsock1(intMax).LocalPort = 0
        Winsock1(intMax).Accept requestID
        List1.AddItem "Conexão iniciada para: " & Winsock1(Index).RemoteHostIP & "  Em: " & Now
    End If
End Sub
 
Private Sub Winsock1_DataArrival(Index As Integer, ByVal bytesTotal As Long)
Dim strIncoming As String, Result As String
Dim sString As String, MyArray() As String
 
    Winsock1(Index).GetData strIncoming
 
    List1.AddItem strIncoming
 
    Winsock1(Index).SendData Result
    
End Sub
 
'''''Client Code
Private Sub Command1_Click()
 
If Winsock2.State <> sckClosed Then Winsock2.Close
 
    Winsock2.RemotePort = Combo1.Text
    Winsock2.RemoteHost = Combo2.Text
 
    Winsock2.Connect
 
' Try and Connect to the Server
Do Until Winsock2.State = sckConnected
    DoEvents: DoEvents: DoEvents: DoEvents
    If Winsock2.State = sckError Then
        MsgBox "There was a problem connecting to the Server!" & vbCrLf & "Please try again later!", vbOKOnly, "Connection Error"
        Exit Sub
    End If
Loop
 
Winsock2.SendData Now & " »»> " & Text1.Text
Command2.Enabled = True
Text1.Enabled = True
Command1.Enabled = False
 
End Sub
 
 
 
Private Sub Winsock2_ConnectionRequest(ByVal requestID As Long)
        intMax = intMax + 1
      
        Winsock1(intMax).LocalPort = 0
        Winsock1(intMax).Accept requestID
        List1.AddItem "Conexão iniciada para: " & Winsock1(Index).RemoteHostIP & "  Em: " & Now
        Winsock2.SendData "Conexão iniciada para: " & Winsock1(Index).RemoteHostIP & "  Em: " & Now
 
    Winsock2.RemotePort = Combo1.Text
    Winsock2.RemoteHost = Winsock1(Index).RemoteHostIP
 
    Winsock2.Connect
 
' Try and Connect to the Server
Do Until Winsock2.State = sckConnected
    DoEvents: DoEvents: DoEvents: DoEvents
    If Winsock2.State = sckError Then
        MsgBox "There was a problem connecting to the Server!" & vbCrLf & "Please try again later!", vbOKOnly, "Connection Error"
        Exit Sub
    End If
Loop
 
Winsock2.SendData Now & " »»> " & Text1.Text
Command2.Enabled = True
Text1.Enabled = True
Command1.Enabled = False
 
 
 
 
End Sub
 
Private Sub Winsock2_DataArrival(ByVal bytesTotal As Long)
Dim strReply As String
 
    Winsock2.GetData (strReply)
   
        MsgBox strReply
 
End Sub

thanks in advance

[randem]

Daskalos,

Clarify, What do you mean both sides connect?

[Daskalos]

well... if 2 computers are using the program, one of them connects to other IP and sends a message', it works fine, but when the second person try to send a message, it says that there are an error in protocol, so the second person has to get the 1st person IP and connects to it

undestand now???

[randem]

Daskalos,

Still not clear on what you mean, but if you are writting a chat program you probably want to use the UDP protocol not the TCP protocol. The difference is that in UDP you do not have to be connected at all times it only connect when you are sending something then disconnects but stays open and your communications is not guaranteed delivery.

Usually when you get the protocol error, it means that you are attempting to send on a port that is in the process of receiving at the moment. So you may want to put in a loop that will let you know when it is done then request a send.

[Daskalos]

thanks for the advice...
to use the UDP protocol, what I have to do???

talking about the error... I don't know what to do... Chatter1 have to get Chatter2 IP and conect to send messages and Chatter2 have to get Chatter1 IP to send messages... What i want to do was Chatter1 gets Chatter2 IP than he conects and both Chatters send messages to each other.

Do I make myself clear now??

THanks in advance

[hortongeo]

if you want to have the winsock to accept the connection when a connection request is sent then all you need to do is

Private Sub ws_ConnectionRequest(ByVal requestID As Long)
ws.Close
ws.Accept requestID
End Sub

this should do what you ask.

however you seem to want to have multiple connections.

for this you could use UDP for the connections, as this does not need any handshaking, but is then not very secure.

the code you used

Private Sub Winsock1_ConnectionRequest(Index As Integer, ByVal requestID As Long)
    If Index = 0 Then
        intMax = intMax + 1
        Load Winsock1(intMax)
        Winsock1(intMax).LocalPort = 0
        Winsock1(intMax).Accept requestID
        List1.AddItem "Conexão iniciada para: " & Winsock1(Index).RemoteHostIP & "  Em: " & Now
    End If
End Sub

should work.

also when you accept a connection both sides will be connected to each other.

[Daskalos]

so, if I want to change my program from TCP to UDP I don't have to change anything in the code (only the winsock.listen)
and then change Winsock protocols??

[randem]

Daskalos,

Basically - Yes.