making this code neeeaaat....

[ianpaisley]

I'm pretty sure my code below doesn't need to be repeated. I'd appreciate if someone could show me how to tidy it up a bit - it works fine, but I know it could be neater.

Thanks for any help!

'Two command buttons and a textbox. The command buttons are 'for back and forward, through the text.

Dim MyText(0 To 5), CurText


Private Sub Command1_Click()
MyText(0) = "Yadayada"
MyText(1) = "Chicaboom"
MyText(2) = "Spaceman!"
MyText(3) = "Everybody"
MyText(4) = "Mr Bombastic"
MyText(5) = "Get Up, Get Up!!"
If CurText <> 0 Then
Form1.Text1.Text = MyText(CurText - 1)
CurText = CurText - 1
End If
End Sub

Private Sub Command2_Click()
MyText(0) = "Yadayada"
MyText(1) = "Chicaboom"

MyText(2) = "Spaceman!"
MyText(3) = "Everybody"
MyText(4) = "Mr Bombastic"
MyText(5) = "Get Up, Get Up!!"
If CurText <> 5 Then
Form1.Text1.Text = MyText(CurText + 1)
CurText = CurText + 1
End If
If CurText = 5 Then
Form1.Text1.Text = MyText(CurText)
End If
End Sub

[Sam Finch]

Just move the

MyText(0) = "Yadayada"
MyText(1) = "Chicaboom"
MyText(2) = "Spaceman!"
MyText(3) = "Everybody"
MyText(4) = "Mr Bombastic"
MyText(5) = "Get Up, Get Up!!"

into the Form_Load Event

1) You can replace all the Form1.Text1.Text with Text1.Text, VB automatically knows it's on Form1.
2) Move variable initalization into your Form_Load event.
3) Try using TAB in order to tell apart nested code snippets.
Example:
instead of:

If i=1 then
select case
case b
b=j
end select
end if

try:

if i=1 then
select case
case b
b=j
end select
end if

it's much more readable.

put one empty line between code parts that do different stuff, again, in order to tell apart.

That's it

[ianpaisley]

I have 'Form1.text1.text' because the above code is actually in a module which is called when the user clicks the back and forward buttons:

'In form1:

Private Sub Command1_Click()
Call backwards
End Sub

Private Sub Command2_Click()
Call forwards
End Sub

So I have to have 'Form1', so module will know what to do. Likewise, Sam, I can't use form_load. Is there any Module_Load event or something?

Public Sub backwards()

MyText(0) = "Yadayada"
MyText(1) = "Chicaboom"
MyText(2) = "Spaceman!"
MyText(3) = "Everybody"
MyText(4) = "Mr Bombastic"
MyText(5) = "Get Up, Get Up!!"
If CurText <> 0 Then
Form1.Text1.Text = MyText(CurText - 1)
CurText = CurText - 1
End If
End Sub

Public Sub forwards()
MyText(0) = "Yadayada"
MyText(1) = "Chicaboom"
MyText(2) = "Spaceman!"
MyText(3) = "Everybody"
MyText(4) = "Mr Bombastic"
MyText(5) = "Get Up, Get Up!!"
If CurText <> 5 Then
Form1.Text1.Text = MyText(CurText + 1)
CurText = CurText + 1
End If
If CurText = 5 Then
Form1.Text1.Text = MyText(CurText)
End If
End Sub

[(B2F)Tom]

Even if your code is in a module, you can put it in then Form_Load of the Form you first call (see the properties of your project).

You can remove the .text of your textbox because it is the textbox default property (it's a detail but more easy to read)

put some tabulations to your code as scOrp said :

If a=x Then
a=4
Else
a=9
Endif

will done:

If a=x Then
a=4
Else: a=9
Endif

for now, it's the only thing I can tell you.

[Iain17]

So make a init sub in the mosule that initilaes the values. Call this from form1's load event.

Private Sub InitTextValues()
  MyText(0) = "Yadayada" 
  MyText(1) = "Chicaboom" 
  MyText(2) = "Spaceman!" 
  MyText(3) = "Everybody" 
  MyText(4) = "Mr Bombastic" 
  MyText(5) = "Get Up, Get Up!!" 
End Sub


'Form1
Private Sub Form_Load()
  InitTextValues
End Sub

[(B2F)Tom]

..., the spaces don't appear!!!!!!!!!!


Eh, Lain17, Can you tell me how you did to insert pretty form code in your reply ?


[Edited by (B2F)Tom on 07-06-2000 at 05:18 AM]

[Iain17]

(B2F)Tom,

Check out :

http://forums.vb-world.net/index.php?action=bbcode

The name is Iain17 any way. Thats with an i. Everyone seems to get that wrong. Oh well.

[(B2F)Tom]

Sorry Iain17, I'll never do that again.
Anyway, thanks for your tip !

[Iain17]

No worries mate.

Maybe i will have to include in my signature that it is an i.