Need some help with a program...

[mysteryman]

I am pretty new to C++ and the whole programming bit. I am trying to write a program that will display the "Twelve Days of Christmas" song, and need some help... I see there is a problem using apstring to intialize day_of_christmas, and don't know what else to use. Any help is appreciated! Thanks in advance!

/*
Josh
christmas.cpp
*/

#include <iostream.h>
#include <apstring.h>

int main()
{
	apstring day_of_christmas;
	
	switch(day_of_christmas) {
	case 12:
		cout << "Twelth";
	case 11:
		cout << "Eleventh";
	case 10:
		cout << "Tenth";
	case 9:
		cout << "Ninth";
	case 8:
		cout << "Eighth";
	case 7:
		cout << "Seventh";
	case 6:
		cout << "Sixth";
	case 5:
		cout << "Fifth";
	case 4:
		cout << "Fourth";
	case 3:
		cout << "Third";
	case 2:
		cout << "Second";
	case 1:
		cout << "First";
	}

	cout << "On the " << day_of_christmas << " day of Christmas, " << endl;
	cout << "My true love gave to me " << endl;

	switch(day_of_christmas) {
	case 12:
		cout << "Twelve drummers drumming";
	case 11:
		cout << "Eleven pipers piping";
	case 10:
		cout << "Ten lords a-leaping";
	case 9:
		cout << "Nine ladies dancing";
	case 8:
		cout << "Eight maids a-milking";
	case 7:
		cout << "Seven swans a-swimming";
	case 6:
		cout << "Six geese a laying";
	case 5:
		cout << "Five golden rings!";
	case 4:
		cout << "Four calling birds";
	case 3:
		cout << "Three french hens";
	case 2:
		cout << "Two turtle doves";
	case 1:
		cout << "A partridge in a pear tree";
	}

	return 0;
}

[filburt1]

You can't do a switch on an apstring; you've got to do a bunch of ifs and else ifs.

[SteveCRM]

Well first of all...day_of_christmas never changes. you have switch statement, but it will never run....like saying if day of christmas is 12 then....when it hasn't been set to anything. Put this in a loop and have it increment each time

Originally posted by mysteryman

/*
Josh
christmas.cpp
*/

#include <iostream.h>
#include <apstring.h>

int main()
{
	apstring day_of_christmas;
	
	switch(day_of_christmas) {
	case 12:
		cout << "Twelth";
	case 11:
		cout << "Eleventh";
	case 10:
		cout << "Tenth";
	case 9:
		cout << "Ninth";
	case 8:
		cout << "Eighth";
	case 7:
		cout << "Seventh";
	case 6:
		cout << "Sixth";
	case 5:
		cout << "Fifth";
	case 4:
		cout << "Fourth";
	case 3:
		cout << "Third";
	case 2:
		cout << "Second";
	case 1:
		cout << "First";
	}

	cout << "On the " << day_of_christmas << " day of Christmas, " << endl;
	cout << "My true love gave to me " << endl;

	switch(day_of_christmas) {
	case 12:
		cout << "Twelve drummers drumming";
	case 11:
		cout << "Eleven pipers piping";
	case 10:
		cout << "Ten lords a-leaping";
	case 9:
		cout << "Nine ladies dancing";
	case 8:
		cout << "Eight maids a-milking";
	case 7:
		cout << "Seven swans a-swimming";
	case 6:
		cout << "Six geese a laying";
	case 5:
		cout << "Five golden rings!";
	case 4:
		cout << "Four calling birds";
	case 3:
		cout << "Three french hens";
	case 2:
		cout << "Two turtle doves";
	case 1:
		cout << "A partridge in a pear tree";
	}

	return 0;
}

[mysteryman]

I can only use repetition and switch structures to do this... I need to use one switch structure for the day (First, Second, etc), and one switch structure for the rest of the verse. Thats where I am stuck, it is possible to do it with an if/else or for loop, but I can't figure out how to do it with two switch structures...

[mysteryman]

Apstring is like a regular string, but is easier to use (in my opinion).

[mysteryman]

Okay, here is what I have so far... Still need some help to get it working...

#include <iostream.h>

int main()
{
	char day_of_christmas[10];
	
	switch(day_of_christmas) {
	case 12:
		cout << "Twelth";
	case 11:
		cout << "Eleventh";
	case 10:
		cout << "Tenth";
	case 9:
		cout << "Ninth";
	case 8:
		cout << "Eighth";
	case 7:
		cout << "Seventh";
	case 6:
		cout << "Sixth";
	case 5:
		cout << "Fifth";
	case 4:
		cout << "Fourth";
	case 3:
		cout << "Third";
	case 2:
		cout << "Second";
	case 1:
		cout << "First";
	}

	cout << "On the " << day_of_christmas << " day of Christmas, " << endl;
	cout << "My true love gave to me " << endl;

	switch(day_of_christmas) {
	case 12:
		cout << "Twelve drummers drumming";
	case 11:
		cout << "Eleven pipers piping";
	case 10:
		cout << "Ten lords a-leaping";
	case 9:
		cout << "Nine ladies dancing";
	case 8:
		cout << "Eight maids a-milking";
	case 7:
		cout << "Seven swans a-swimming";
	case 6:
		cout << "Six geese a laying";
	case 5:
		cout << "Five golden rings!";
	case 4:
		cout << "Four calling birds";
	case 3:
		cout << "Three french hens";
	case 2:
		cout << "Two turtle doves";
	case 1:
		cout << "A partridge in a pear tree";
	}

	return 0;
}

[filburt1]

You don't need to make an array of chars, just use a single char. A char is really just a number that happens to represent an ASCII character.

[SteveCRM]

well you can't store "Eleventh" in one character!

[SteveCRM]

put it in a loop..you aren't setting it to anything..

[filburt1]

Originally posted by SteveCRM
well you can't store "Eleventh" in one character!

He's not storing a string, only a number.

[parksie]

Just as a note, apstring is now offically deprecated in favour of string

[SteveCRM]

woops sorry filbut....read that a little too fast then why not use an int???

mike: I hated string....thats the cheating way do you have a copy of apstring? I dont think my school will like me taking their files

[filburt1]

Originally posted by SteveCRM
woops sorry filbut....read that a little too fast then why not use an int???

A char takes up only one byte of RAM.

[filburt1]

Originally posted by SteveCRM
mike: I hated string....thats the cheating way do you have a copy of apstring? I dont think my school will like me taking their files

http://www.collegeboard.org/ap/compu...l/classes.html

[parksie]

Originally posted by filburt1
A char takes up only one byte of RAM.

Not necessarily...although sizeof(char) is defined to be 1, it doesn't mean that a char takes up one byte on the target system.

In fact, the target system may have no conception of bits and bytes

I love being a techy

[filburt1]

Thanks for thoroughly shooting down and nuking that idea.

[parksie]

You're welcome

Although if you stick to conventional processors (MIPS, ARM, x86) then what you say is correct

[CornedBee]

While the others are talking, here's the code:

/*
Josh
christmas.cpp
*/
#include <iostream>
#include <string>
using namespace std;

int main()
{
string day_of_christmas;
int day;  // memory doesn't matter in such a program, and it cannot be mistaken
for(day = 1; day <= 12; day++)
{
switch(day)
 {
	case 12:
                                day_of_christmas = "Twelth";
		cout << ;
	case 11:
                                day_of_christmas = "Eleventh";
		cout << 
	case 10:
                                day_of_christmas = "Tenth";
		cout << 
	case 9:
                                day_of_christmas = "Ninth";
		cout << 
	case 8:
                                day_of_christmas = "Eighth";
		cout << 
	case 7:
                                day_of_christmas = "Seventh";
		cout << 
	case 6:
                                day_of_christmas = "Sixth";
		cout << 
	case 5:
                                day_of_christmas = "Fifth";
		cout << 
	case 4:
                                day_of_christmas = "Fourth";
		cout << 
	case 3:
                                day_of_christmas = "Third";
		cout << 
	case 2:
                                day_of_christmas = "Second";
		cout << 
	case 1:
                                day_of_christmas = "First";
		cout << 
	}
	cout << "On the " << day_of_christmas << " day of Christmas, " << endl;
	cout << "My true love gave to me " << endl;	switch(day)
 {
	case 12:
		cout << "Twelve drummers drumming";
	case 11:
		cout << "Eleven pipers piping";
	case 10:
		cout << "Ten lords a-leaping";
	case 9:
		cout << "Nine ladies dancing";
	case 8:
		cout << "Eight maids a-milking";
	case 7:
		cout << "Seven swans a-swimming";
	case 6:
		cout << "Six geese a laying";
	case 5:
		cout << "Five golden rings!";
	case 4:
		cout << "Four calling birds";
	case 3:
		cout << "Three french hens";
	case 2:
		cout << "Two turtle doves";
	case 1:
		cout << "A partridge in a pear tree";
	}
         }
          return 0;
}

also, add a
break;
at the end of each case. I'm too lazy to do that. :P
I also don't know why aou reversed the order of the cases, but that's your problem too.

[parksie]

Don't put break, because then it falls through, so that if you have 5, it goes through five gold rings, four calling birds, etc.

Quite nifty really

[CornedBee]

Oh, yeah, I forgot the song. Well, actually I know it only from blizzard's sc map "Twelve Days of Christmas".
You're right parksie.
Mysteryman: put the breaks only in the first switch block. And remove or complete the cout instructions (I got the days from there and forgot to remove the remains.

[mysteryman]

okay, thanks!

[CornedBee]

np, I like it